fix(openshift): update Quickstart text/formatting #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
previously approved these changes
Nov 24, 2023
cmah88
reviewed
Nov 24, 2023
cmah88
reviewed
Nov 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
* fix(openshift): update Quickstart text/formatting * Update final task description * Add additional port verification step (cherry picked from commit e8e0bef)
ebaron
added a commit
that referenced
this pull request
Nov 24, 2023
* fix(openshift): update Quickstart text/formatting * Update final task description * Add additional port verification step (cherry picked from commit e8e0bef) Co-authored-by: Elliott Baron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Related to: #668
Description of the change:
Fixes indentation and fields. Removes explicit summary of tasks since this is already generated when working through the Quickstart. Removed placeholder text and summary fields. Generally followed the example of our existing quickstart: openshift/console-operator#770
Motivation for the change:
When installing the bundle with the Quickstart included, I see the following errors:
How to manually test:
oc create -f config/openshift/cryostat-quickstart.yaml