chore(makefile): option to generate bundles with quickstart on ocp #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thuan Vo <[email protected]>
andrewazores
approved these changes
Nov 23, 2023
|
Thanks @tthvo! |
mergify bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
) Signed-off-by: Thuan Vo <[email protected]> (cherry picked from commit 04b0fbb)
ebaron
pushed a commit
that referenced
this pull request
Nov 24, 2023
) (#689) Signed-off-by: Thuan Vo <[email protected]> (cherry picked from commit 04b0fbb) Co-authored-by: Thuan Vo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Related to #668
Description of the change:
Added an option (Makefile) to generate the bundle with OpenShift manifests. Default to Kubernetes.
Motivation for the change:
Avoid the need to manually edit the kustomize file when building bundles for OCP. I used this to check out the #668 so I thought it would be nice to have it here.
How to manually test: