added JSToday in the list #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hacktoberfest-swag-list ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
docs/list.md
Outdated
|
|
||
| - **Swag**: Stickers | ||
| - **Requirements**: Submit at least four valid pull requests to any public repository on GitHub: | ||
| - Your pull requests must be accepted and merged or approved according to Hacktoberfest |
vimode
reviewed
Oct 2, 2024
docs/list.md
Outdated
| - **Swag**: Stickers | ||
| - **Requirements**: Submit at least four valid pull requests to any public repository on GitHub: | ||
| - Your pull requests must be accepted and merged or approved according to Hacktoberfest. | ||
| - Once you’ve made your contributions, tweet or post on social media tagging @todayJavaScript with the hashtag #Hacktoberfest2024. |
|
Code Climate has analyzed commit b55d65e and detected 0 issues on this pull request. View more on Code Climate. |
|
Hi @githubashutoshsoni, thank you for your PR. I encourage you to slow down and take your time, as there were several changes I had to make to your PR, including adding an How to sign up section, the Please don't just copy and paste from the company's website as well, as the language doesn't match what we need on the list. I would like to add JSToday to the list, so will merge your fixed PR, but please take these things into account when submitting another PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀