Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected grammar of the list file #832

Closed
wants to merge 1 commit into from

Conversation

siddwarr
Copy link

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2023

Code Climate has analyzed commit aca0714 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit aca0714
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/652a60917313400008c4d744
😎 Deploy Preview https://deploy-preview-832--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@crweiner
Copy link
Owner

Hi @siddwarr! I appreciate your PR, thank you for looking through the repo for ways it can improve.

We have merged several other PRs since you opened this one that could probably use some updating, and I don't 100% agree with every tweak you've presented. However, you do raise some good points and I'll sweep through the List for some grammar corrections before bundling up the repo at the end of Hacktoberfest.

I hope you are having a great Hacktoberfest and we'll see you again next year!

@crweiner crweiner closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants