Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quine to the list #826

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Added Quine to the list #826

merged 5 commits into from
Oct 26, 2023

Conversation

bharatr21
Copy link
Contributor

@bharatr21 bharatr21 commented Oct 12, 2023

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Closes #825
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

Keeping it in draft since Quine said they will be adding more details in this Twitter Thread

docs/list.md Outdated
#### **Quine**

- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile.
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

docs/list.md Show resolved Hide resolved
docs/list.md Outdated
#### **Quine**

- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile.
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline HTML

docs/list.md Outdated
#### **Quine**

- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile.
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline HTML

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit a92e3ef
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/652be22053eed20009563af5
😎 Deploy Preview https://deploy-preview-826--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vimode
Copy link
Contributor

vimode commented Oct 13, 2023

I think with the latest tweet(which you already added) it has enough details to be added to the list. Go ahead fix those errors and make this a PR.

@bharatr21 bharatr21 marked this pull request as ready for review October 13, 2023 11:47
@bharatr21
Copy link
Contributor Author

@vimode I think it's ready for review now

Copy link
Contributor

@vimode vimode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should simply it a bit more, don't you think?
If these edits cause any code climate errors, please fix those.
Thank you.

docs/list.md Outdated Show resolved Hide resolved
docs/list.md Outdated Show resolved Hide resolved
docs/list.md Outdated Show resolved Hide resolved
docs/list.md Outdated Show resolved Hide resolved
Apply code review suggestions

Co-authored-by: vimode <[email protected]>
docs/list.md Outdated

- **Swag**: Exclusive Quine merch.
- **Requirements**:
- Valid PRs starting from October 12th - October 31st.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

docs/list.md Outdated
- **Swag**: Exclusive Quine merch.
- **Requirements**:
- Valid PRs starting from October 12th - October 31st.
- Contributions should be made to issues with the `hacktoberfest` label in repos found at Quine (after clicking on "Contribute").
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

docs/list.md Outdated
- Be in the top 50 contributors of [this leaderboard](https://quine.sh/hacktoberfest?type=developers&sortBy=col1&taggedPrsOnly=true).
- **How to sign up**: Log in to Quine via GitHub and click on the Contribute tab to search for repos to contribute.
- **Issues**: Open issues for eligible repos at the [Quine contribute page](https://quine.sh/contribute).
- **Notes**:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

docs/list.md Outdated
- **How to sign up**: Log in to Quine via GitHub and click on the Contribute tab to search for repos to contribute.
- **Issues**: Open issues for eligible repos at the [Quine contribute page](https://quine.sh/contribute).
- **Notes**:
- Check out the [announcement tweet](https://twitter.com/quine_sh/status/1712434350921322818) and [this twitter thread](https://twitter.com/quine_sh/status/1712081594431782973) for details.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

@codeclimate
Copy link

codeclimate bot commented Oct 15, 2023

Code Climate has analyzed commit a92e3ef and detected 0 issues on this pull request.

View more on Code Climate.

@bharatr21 bharatr21 requested a review from vimode October 15, 2023 12:59
@bharatr21
Copy link
Contributor Author

Applied the suggestions and fixed whitespace/code climate issues,
@vimode please re-review

@crweiner
Copy link
Owner

Thank you very much @vimode and @bharatr21 for working together to add Quine to the Hacktoberfest Swag List for 2023! Let's get them up there!

clapping

@crweiner crweiner merged commit 6e1e418 into crweiner:master Oct 26, 2023
@crweiner crweiner added hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Quine to Hacktoberfest Swag List
3 participants