-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Quine to the list #826
Conversation
docs/list.md
Outdated
#### **Quine** | ||
|
||
- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile. | ||
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
docs/list.md
Outdated
#### **Quine** | ||
|
||
- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile. | ||
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline HTML
docs/list.md
Outdated
#### **Quine** | ||
|
||
- **Swag**: Top 50 contributors get exclusive Quine merch, all participants get a Hacktoberfest Badge on their profile. | ||
- **Requirements**: Valid PRs starting from October 12<sup>th</sup> - October 31<sup>st</sup>. Contributions should be made in repos found on Quine (after clicking on "Contribute") and have the `hacktoberfest` label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline HTML
✅ Deploy Preview for hacktoberfest-swag-list ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think with the latest tweet(which you already added) it has enough details to be added to the list. Go ahead fix those errors and make this a PR. |
@vimode I think it's ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should simply it a bit more, don't you think?
If these edits cause any code climate errors, please fix those.
Thank you.
Apply code review suggestions Co-authored-by: vimode <[email protected]>
docs/list.md
Outdated
|
||
- **Swag**: Exclusive Quine merch. | ||
- **Requirements**: | ||
- Valid PRs starting from October 12th - October 31st. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
- **Swag**: Exclusive Quine merch. | ||
- **Requirements**: | ||
- Valid PRs starting from October 12th - October 31st. | ||
- Contributions should be made to issues with the `hacktoberfest` label in repos found at Quine (after clicking on "Contribute"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
- Be in the top 50 contributors of [this leaderboard](https://quine.sh/hacktoberfest?type=developers&sortBy=col1&taggedPrsOnly=true). | ||
- **How to sign up**: Log in to Quine via GitHub and click on the Contribute tab to search for repos to contribute. | ||
- **Issues**: Open issues for eligible repos at the [Quine contribute page](https://quine.sh/contribute). | ||
- **Notes**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
docs/list.md
Outdated
- **How to sign up**: Log in to Quine via GitHub and click on the Contribute tab to search for repos to contribute. | ||
- **Issues**: Open issues for eligible repos at the [Quine contribute page](https://quine.sh/contribute). | ||
- **Notes**: | ||
- Check out the [announcement tweet](https://twitter.com/quine_sh/status/1712434350921322818) and [this twitter thread](https://twitter.com/quine_sh/status/1712081594431782973) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces
Code Climate has analyzed commit a92e3ef and detected 0 issues on this pull request. View more on Code Climate. |
Applied the suggestions and fixed whitespace/code climate issues, |
Thank you very much @vimode and @bharatr21 for working together to add Quine to the Hacktoberfest Swag List for 2023! Let's get them up there! |
Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:
Closes #825
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀
Keeping it in draft since Quine said they will be adding more details in this Twitter Thread