Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OpenBB in the list #814

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Added OpenBB in the list #814

merged 9 commits into from
Oct 26, 2023

Conversation

vaibhav-009
Copy link
Contributor

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

Fixes #813

@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit f9d810b
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/653555e0b70d03000768150c
😎 Deploy Preview https://deploy-preview-814--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 10, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

crweiner
crweiner reviewed Oct 11, 2023
View reviewed changes
docs/list.md Outdated
- 5 no-code contributions
- 3 code/performance enhancements
- 1 non-extension feature
- **How to sign up**: No special signup required.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vaibhav-009! The OpenBB team does have a swag signup process available here: https://openbb.co/blog/hacktoberfest-join-us-in-celebrating-open-source

Can you please summarize things and include the steps from that page where it says "Once you've completed your contribution, please follow these steps:"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @crweiner I have made the requested changes. can you please review it.

@codeclimate
Copy link

codeclimate bot commented Oct 22, 2023

Code Climate has analyzed commit f9d810b and detected 0 issues on this pull request.

View more on Code Climate.

@crweiner
Copy link
Owner

That's great, thank you for your edits @vaibhav-009 and for adding OpenBB to the Hacktoberfest Swag List!

@crweiner crweiner merged commit 0dd2b0f into crweiner:master Oct 26, 2023
6 checks passed
@crweiner crweiner added hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crweiner crweiner crweiner left review comments

Assignees
No one assigned
Labels
hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OpenBB to Hacktoberfest Swag List
2 participants
@vaibhav-009 @crweiner