Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Odigos in the list #805

Closed
wants to merge 2 commits into from
Closed

Added Odigos in the list #805

wants to merge 2 commits into from

Conversation

Shorya18
Copy link
Contributor

@Shorya18 Shorya18 commented Oct 9, 2023

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up
    Add Odigos to the Hacktoberfest Swag List #801
    Thanks and Happy Hacktoberfest! 🎉
    Tagging @crweiner to take a look. 👀

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit ba81b4a and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit ba81b4a
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/6524140361e55a0008c07392
😎 Deploy Preview https://deploy-preview-805--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@crweiner
Copy link
Owner

crweiner commented Oct 9, 2023

Hello @Shorya18! Can you please update this PR title to reflect the company you're looking to add to the Swag List, and verify that all looks as intended in the site preview: https://deploy-preview-805--hacktoberfest-swag-list.netlify.app/list/#odigos

There are some formatting issues I'd love for you to see and change. Be sure you're following the Contributing guide. Thanks!

@Shorya18 Shorya18 changed the title Newb Added Odigos in the list Oct 10, 2023
@Shorya18
Copy link
Contributor Author

Hello @Shorya18! Can you please update this PR title to reflect the company you're looking to add to the Swag List, and verify that all looks as intended in the site preview: https://deploy-preview-805--hacktoberfest-swag-list.netlify.app/list/#odigos

There are some formatting issues I'd love for you to see and change. Be sure you're following the Contributing guide. Thanks!

Hey I have changed the tittle name to the company's name which I want to add in the list.
thanks

@crweiner crweiner linked an issue Oct 10, 2023 that may be closed by this pull request
Copy link
Owner

@crweiner crweiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shorya18, thank you for updating the title of this PR to match the organization you are looking to add! I would like to give you a chance to review the things I've pointed out as well. Please be sure to view the Netlify deployment and make sure that everything for Odigos looks as intended.

Please ping me when you'd like me to take another look, thanks!

- **Requirements**: Make 3 successful merged PRs by October 20,2023 to win swags
- **How to sign up**: No special signup known.
- **Issues**: All the [open issues](https://github.com/keyval-dev/odigos/issues)
- **Notes**: [Full details are mentioned [here](https://github.com/keyval-dev/odigos/blob/main/README.md).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Notes**: [Full details are mentioned [here](https://github.com/keyval-dev/odigos/blob/main/README.md).
- **Notes**: Full details are mentioned [here in the repo Readme](https://github.com/keyval-dev/odigos/blob/main/README.md).

The

@@ -424,6 +424,14 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers

### O

#### *Odigos*

- **Swag**: Swag (Specific Swags not mentioned)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The swag is mentioned in the Readme file, can you please update this?

#### *Odigos*

- **Swag**: Swag (Specific Swags not mentioned)
- **Requirements**: Make 3 successful merged PRs by October 20,2023 to win swags
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please watch your spacing here

Suggested change
- **Requirements**: Make 3 successful merged PRs by October 20,2023 to win swags
- **Requirements**: Make 3 successful merged PRs by October 20, 2023

@vimode
Copy link
Contributor

vimode commented Oct 20, 2023

Hey @crweiner I think some of these old PRs which are not being updated by the PR authors should be closed and corresponding issues be made open for others to add them to the list. It would be much simpler for you.

@crweiner
Copy link
Owner

Closed due to inactivity

@crweiner crweiner closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Odigos to the Hacktoberfest Swag List
3 participants