Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stackbuilders in the list #775

Merged
merged 8 commits into from
Oct 8, 2023
Merged

Conversation

vaibhav-009
Copy link
Contributor

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

Fixes #773

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit b2641fe
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/6522ea18d272860008c0959f
😎 Deploy Preview https://deploy-preview-775--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@crweiner
Copy link
Owner

crweiner commented Oct 7, 2023

Hi @vaibhav-009! Thank you for your PR!

It looks like Stackbuilders has a few more requirements from this Guidelines & Evaluation Criteria PDF file. Can you please make sure that the Requirements section of the list reflects what the PDF says?

Thanks!

docs/list.md Outdated Show resolved Hide resolved
docs/list.md Show resolved Hide resolved
docs/list.md Outdated Show resolved Hide resolved
docs/list.md Outdated Show resolved Hide resolved
@vaibhav-009
Copy link
Contributor Author

@crweiner updated the requirements for stack builder

@codeclimate
Copy link

codeclimate bot commented Oct 8, 2023

Code Climate has analyzed commit b2641fe and detected 0 issues on this pull request.

View more on Code Climate.

@crweiner
Copy link
Owner

crweiner commented Oct 8, 2023

Hi @vaibhav-009! Thank you for adding Stack Builders to the Hacktoberfest Swag List! I appreciate you making the changes I brought up as well. Have a great Hacktoberfest! 🎉 🎃

thank you

@crweiner crweiner added hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest labels Oct 8, 2023
@crweiner crweiner merged commit cd4aed1 into crweiner:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Stack Builders to the Hacktoberfest Swag List
2 participants