-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rock-paper-scissor.py #769
Conversation
elif computer=="rock": | ||
result.config(text="Player Win") | ||
|
||
elif player=="scissor": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
if player==computer: | ||
result.config(text="Its a Tie") | ||
|
||
elif player=="rock": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
elif computer=="scissor": | ||
result.config(text="Player Win") | ||
|
||
elif player=="paper": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 3 locations. Consider refactoring.
|
||
move = ["rock", "paper", "scissor"] | ||
|
||
def fun(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function fun
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Code Climate has analyzed commit b60c6db and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
✅ Deploy Preview for hacktoberfest-swag-list ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @BabbarRaghav. "Contributions" like this are not in the spirit of Hacktoberfest and completely go against the rules. Don't forget, your PRs are public, so everyone can see the spam that you are submitting. You clearly just searched the word "Hacktoberfest" and then submitted the same spam to every repo you found.
This is not how you go about getting a coding career. I have reported all of the spammy repos to the official Hacktoberfest team, so it's now in their hands. Read the official Participation page all the way through and make meaningful, positive contributions during Hacktoberfest. |
Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:
Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀