Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rock-paper-scissor.py #769

Closed
wants to merge 1 commit into from
Closed

Create rock-paper-scissor.py #769

wants to merge 1 commit into from

Conversation

BabbarRaghav
Copy link

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

elif computer=="rock":
result.config(text="Player Win")

elif player=="scissor":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

if player==computer:
result.config(text="Its a Tie")

elif player=="rock":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

elif computer=="scissor":
result.config(text="Player Win")

elif player=="paper":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.


move = ["rock", "paper", "scissor"]

def fun():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function fun has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Oct 5, 2023

Code Climate has analyzed commit b60c6db and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 3

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit b60c6db
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/651efd179898050009e0d7d7
😎 Deploy Preview https://deploy-preview-769--hacktoberfest-swag-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@crweiner crweiner added the spam You know what you've done label Oct 6, 2023
@crweiner
Copy link
Owner

crweiner commented Oct 6, 2023

Hi @BabbarRaghav. "Contributions" like this are not in the spirit of Hacktoberfest and completely go against the rules. Don't forget, your PRs are public, so everyone can see the spam that you are submitting. You clearly just searched the word "Hacktoberfest" and then submitted the same spam to every repo you found.

This is not how you go about getting a coding career. I have reported all of the spammy repos to the official Hacktoberfest team, so it's now in their hands.

Read the official Participation page all the way through and make meaningful, positive contributions during Hacktoberfest.

@crweiner crweiner closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spam You know what you've done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants