Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reduce amount of requests to download localization. #286

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

serhii-londar
Copy link
Collaborator

Add saving downloaded files timestamps.
Download files only when saved file timestamp is not equal to manifest timestamp.
Add minimum update interval for downloading manifest.

@crowdin-bot
Copy link
Collaborator

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 50b9006

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.98%. Comparing base (db1af96) to head (50b9006).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ders/Crowdin/ManifestManager/ManifestManager.swift 73.34% 8 Missing ⚠️
...tionDownloader/CrowdinLocalizationDownloader.swift 70.84% 7 Missing ⚠️
...Crowdin/ManifestManager/FileTimestampStorage.swift 83.34% 4 Missing ⚠️
...ers/Crowdin/CrowdinRemoteLocalizationStorage.swift 33.34% 2 Missing ⚠️
...rs/Crowdin/Extensions/CrowdinSDK+ReactNative.swift 0.00% 2 Missing ⚠️
...wdin/MappingDownloader/CrowdinMappingManager.swift 0.00% 2 Missing ⚠️
...oviders/Crowdin/Config/CrowdinProviderConfig.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   61.85%   61.98%   +0.13%     
==========================================
  Files         121      122       +1     
  Lines        4325     4395      +70     
==========================================
+ Hits         2675     2724      +49     
- Misses       1650     1671      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add ability to enter screenshot name while capturing from floating button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants