Gcw 1752 ember upgrade to 2.18 #598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrataukirde
requested review from
abulsayyad123,
swatijadhav,
patrixr,
abhinav098,
akshaygwd and
steveyken
patrixr
reviewed
Feb 3, 2020
| } else { | ||
| this.get("messageBox").custom( | ||
| "Cancel this Request?", | ||
| "Not Now", null, | ||
| "Cancel Request", () => this.send("removeOrder")); | ||
| "Not Now", |
There was a problem hiding this comment.
unrelated to this PR, just a reminder for us to translate those strings
patrixr
approved these changes
Feb 3, 2020
|
I've marked this as draft PR now and assigned it to @abulsayyad123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link:
https://jira.crossroads.org.hk/browse/GCW-1752
What does this PR do?
This PR upgrades the ember version to 2.18.
Note.
Test Cases are commented for now and we need to take care of it as the next phase of this upgrade.
Please review.
Thanks.