Bump controller-runtime to latest, remove the controller engine and GVK routed cache #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
added
the
release/breaking-api-change
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 6, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 7, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 7, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 7, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 9, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 10, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 11, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 14, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
Merged
6 tasks
It's breaking the dependencies of this module, and its only consumer is the c/c repo. It should live there instead. Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
It requires a newer cel-go dependency than the Kubernetes dependencies, which makes updating them difficult. Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 17, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Depends on crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
turkenh
approved these changes
May 20, 2024
2 tasks
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 20, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Per the below PR, the latest crossplane-runtime doesn't have the controller engine anymore. It moved into c/c. crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
negz
added a commit
to negz/crossplane
that referenced
this pull request
May 20, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Per the below PR, the latest crossplane-runtime doesn't have the controller engine anymore. It moved into c/c. crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]>
cychiang
pushed a commit
to cychiang/crossplane
that referenced
this pull request
May 22, 2024
This bumps crossplane-runtime, controller-runtime, and k8s.io dependencies to latest. Per the below PR, the latest crossplane-runtime doesn't have the controller engine anymore. It moved into c/c. crossplane/crossplane-runtime#689 Signed-off-by: Nic Cope <[email protected]> Signed-off-by: Chuan-Yen Chiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR does two things:
pkg/controller- I plan to move this (back) into c/cI'd like to upgrade controller-runtime, because the latest versions have some promising functionality that may help with realtime compositions. You can now stop an informer within a cache, and stop an informer's event handlers. I believe this could eliminate the need for us to create a cache per controller, thus eliminating the need for the GVK routed cache etc.
Unfortunately there are some breaking changes around the
source.Sourceinterface in the latest version of controller-runtime. They break the engine and GVK routed cache implementations.Rather than refactor things here and in c/c to accommodate the breaking changes, I'd like to move everything into c/c. As far as I know c/c is the only consumer of
pkg/controller(except for theOptionsstruct that isn't moving). It's a pain to have to update them in c/cr and then bump c/c. (My bad - I moved the engine here in the first place.)I'll open a c/c PR that copies
pkg/controller.Deleting these is a breaking change, but I don't think it will affect anyone in practice. Based on the below search, no-one but c/c is actually using these types.
https://github.com/search?q=%22github.com%2Fcrossplane%2Fcrossplane-runtime%2Fpkg%2Fcontroller%22&type=code&p=5
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
It's been covered pretty extensively by unit and E2E tests in crossplane/crossplane#5651.