Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update module/project to crossplane-contrib/provider-upjet-github #103

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Oct 7, 2024

Description of your changes

This repository has been generously contributed from its previous source location in coopnorge/provider-github to this new home in crossplane-contrib/provider-upjet-github. Thank you @AtzeDeVries and team for the awesome work on this provider and the willingness to share it even more openly with the Crossplane community!

See crossplane/crossplane#5435 for background context.

This PR updates all of the project module/import/build paths to point to this new source location. This could be a breaking change if other projects outside of this repo were importing them directly for source code usage in their repos, but I doubt that was being done. We took a similar approach recently with crossplane-contrib/provider-upjet-mysql#9.

Note that the CRD API groups aren't updated in this PR, so when folks already using this provider upgrade to the new published location under crossplane-contrib, they shouldn't be impacted at all.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

We will be relying heavily on a successful CI run of unit tests and end to end tests for this provider. Let me know if there's other additional testing we should perform.

Copy link
Collaborator

@AtzeDeVries AtzeDeVries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jbw976
Copy link
Member Author

jbw976 commented Oct 8, 2024

Awesome @AtzeDeVries this PR is passing all checks! I've created the new repo on xpkg.upbound.io with a robot account and updated the secrets that CI will use. I'm hoping after we merge this into main that publishing will work for us successfully 😉

@jbw976 jbw976 merged commit 1c9623d into crossplane-contrib:main Oct 8, 2024
7 checks passed
@jbw976
Copy link
Member Author

jbw976 commented Oct 8, 2024

That looks successful! CI action https://github.com/crossplane-contrib/provider-upjet-github/actions/runs/11230655205 ran and published xpkg.upbound.io/crossplane-contrib/provider-upjet-github:v0.13.0-6.g1c9623d successfully. I was able to install it into a local kind cluster just now with:

❯ cat <<EOF | kubectl apply -f -
apiVersion: pkg.crossplane.io/v1
kind: Provider
metadata:
  name: provider-upjet-github
spec:
  package: xpkg.upbound.io/crossplane-contrib/provider-upjet-github:v0.13.0-6.g1c9623d
EOF

Provider is installed and healthy:

❯ crossplane beta trace provider.pkg.crossplane.io/provider-upjet-github
NAME                                                     VERSION              INSTALLED   HEALTHY   STATE    STATUS
Provider/provider-upjet-github                           v0.13.0-6.g1c9623d   True        True      -        HealthyPackageRevision
└─ ProviderRevision/provider-upjet-github-174dbf259cac   v0.13.0-6.g1c9623d   -           True      Active   HealthyPackageRevision

CRDs are available in the control plane as well:

❯ k get crd | grep github
actionssecrets.actions.github.upbound.io                   2024-10-08T07:41:18Z
actionsvariables.actions.github.upbound.io                 2024-10-08T07:41:18Z
branches.repo.github.upbound.io                            2024-10-08T07:41:18Z
branchprotections.repo.github.upbound.io                   2024-10-08T07:41:18Z
defaultbranches.repo.github.upbound.io                     2024-10-08T07:41:18Z
deploykeys.repo.github.upbound.io                          2024-10-08T07:41:18Z
emugroupmappings.team.github.upbound.io                    2024-10-08T07:41:18Z
memberships.user.github.upbound.io                         2024-10-08T07:41:18Z
organizationrulesets.enterprise.github.upbound.io          2024-10-08T07:41:18Z
organizations.enterprise.github.upbound.io                 2024-10-08T07:41:18Z
providerconfigs.github.upbound.io                          2024-10-08T07:41:18Z
providerconfigusages.github.upbound.io                     2024-10-08T07:41:18Z
pullrequests.repo.github.upbound.io                        2024-10-08T07:41:18Z
repositories.repo.github.upbound.io                        2024-10-08T07:41:18Z
repositoryautolinkreferences.repo.github.upbound.io        2024-10-08T07:41:18Z
repositoryfiles.repo.github.upbound.io                     2024-10-08T07:41:18Z
repositorywebhooks.repo.github.upbound.io                  2024-10-08T07:41:18Z
storeconfigs.github.upbound.io                             2024-10-08T07:41:18Z
teammemberships.team.github.upbound.io                     2024-10-08T07:41:18Z
teamrepositories.team.github.upbound.io                    2024-10-08T07:41:18Z
teams.team.github.upbound.io                               2024-10-08T07:41:18Z
teamsettings.team.github.upbound.io                        2024-10-08T07:41:18Z
teamsyncgroupmappings.team.github.upbound.io               2024-10-08T07:41:18Z

I think a switch needs to be flipped in the xpkg.upbound.io database to make the provider fully public and indexed, I'm following up to do that now.

@AtzeDeVries
Copy link
Collaborator

Awesome!

@jbw976
Copy link
Member Author

jbw976 commented Oct 8, 2024

The provider repo has been set to public in xpkg.upbound.io, so the next official release with a release semver will be indexed and publicly displayed in the marketplace!

@AtzeDeVries feel free to cut the next release at your leisure. If there are any issues with it showing up on https://marketplace.upbound.io/providers/crossplane-contrib/provider-upjet-github after a release, please let me know! That link will be a 404 until a release is completed, then it should work.

Also @AtzeDeVries you are admin on this repo, so please add other maintainers and give them permissions if there were any others not yet captured in https://github.com/crossplane-contrib/provider-upjet-github/blob/main/OWNERS.md.

Let me know if I can be of any further help 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants