-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external name #60
base: main
Are you sure you want to change the base?
Conversation
…nitialization of those fields Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
I'm attempting to address displague/configuration-metalnetworks#2 with this PR. To debug, after installing Crossplane and the configuration-metalnetworks using the instructions from the issue above, I scale the controller replicas to 0:
I then update the CRDs and run the code from this branch using
Update: |
Signed-off-by: Marques Johansson <[email protected]>
…-401b-94e4-deadbeefc0de" for GetIdFn Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Description of your changes
This branch will attempt to address #62, #48 , #50, and #54
This draft currently fixes none of those and is blocked on the following error:
cannot set critical annotations: cannot get external name: cannot find id in tfstate
This was also seen in #48 (comment), where the packngo client SDK reported an error indicating that GET requests are being attempted with an empty string for the resource UUID (external name).
This occurs on observations before any creations. The creations are not attempted.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested