Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling functions emitted by observables #132

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Avoid calling functions emitted by observables #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/observable-hooks/src/use-observable-eager-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function useObservableEagerState<TState>(
if (isAsyncEmissionRef.current) {
// ignore synchronous value
// prevent initial re-rendering
setState(value);
setState(() => value);
} else {
secondInitialValue = value;
}
Expand All @@ -85,7 +85,7 @@ export function useObservableEagerState<TState>(
if (!isAsyncEmissionRef.current) {
// fix #86 where sync emission may happen before useEffect
if (secondInitialValue !== state) {
setState(secondInitialValue);
setState(() => secondInitialValue);
}
}

Expand Down
Loading