New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - add senum to thrift-parser #83

Open

ugodiggi wants to merge 2 commits into creditkarma:master from UrbanCompass:ugo/senum

ugodiggi commented May 16, 2024

A senum is like an enum but does not have the int identifier - so
it is just a string when serialized.

e.g.

senum Foo {
  VAL0,
  VAL1
}

See more details on the rationale here:
https://docs.google.com/document/d/1VuKLrMyYMhEOTCaovQQii2wd0bUhp53FcqAYUeoS-QE/edit

ugodiggi added 2 commits

May 16, 2024 16:38


          Add senum definition.

5820be1

Also, add the relative parser tests and get them to pass.


          Also add senum to all tests that mention enum

aa159f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet