This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
Not to attach inline images that are truncated. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason:
Improvement. Previously deleted image is not visible and becomes
a blank line.
Reason: Improvement. Although this can be move to a independent plug-in.
Reason: Tune for mails from Europe. Text layout is different.
Reason: Creating attachment will also trigger custom_workflow
Reason: Otherwise last picture will always be displayed. This happens on email from China
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for credativUP for creating this plugin and s-sandy for his updating and fixing, so I am able to use this plugin in my Redmine instance -
container sameersbn/redmine-3.3.2
Rails version 4.2.7.1
Ruby version 2.1.9-p490 (x86_64-linux-gnu)
RubyGems version 2.2.5
Rack version 1.6.5
My Redmine instance will attach ALL attachments in eMail regardless of Redmine truncation settings. So I tried to add a workaround and tested it good on my Redmine-3.3.2. Kindly review and then merge it if this is helpful to other people.