Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate build from rollup to vite #225

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: migrate build from rollup to vite #225

merged 2 commits into from
Jun 11, 2024

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Jun 6, 2024

Fix #224.

@dgolovin dgolovin requested review from benoitf and jeffmaury June 6, 2024 02:07
@dgolovin
Copy link
Contributor Author

dgolovin commented Jun 6, 2024

There should be no more macOS build issues and build should be much faster.

jeffmaury
jeffmaury requested changes Jun 6, 2024
View reviewed changes
package.json Show resolved Hide resolved
@dgolovin dgolovin requested a review from jeffmaury June 10, 2024 18:03
jeffmaury
jeffmaury approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit 764cfad into crc-org:main Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch build from rollup to vite
2 participants
@dgolovin @jeffmaury