Show Full User Experience When Running The Installer On Windows #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously the installer was executed as a hidden process and did not show any option to reboot the computer even when it was required. Then the flow keep processing and the setup ended up on an error due to not being able to stop it or to reboot the computer. Also this change makes the openshift local installer matches how other installers are executed showing full experience to the user (i.e. podman installer) Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
previously the installation flow for crc will include the ask for preset popup, which would end up setting the preset on crc config, as now the installation process typically will end up on a reboot we need to ask / recommend the preset when the initialization button is shown after reboot Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
|
/assign @jeffmaury |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #189