Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the KUBECONFIG variable #191

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

danpawlik
Copy link
Contributor

@danpawlik danpawlik commented Jul 9, 2024

Each of the "oc" command that is veryfing the resource
is exiting with error code 1, because the KUBECONFIG is not available.

This commit is partially revert code that was proposed in [1].

[1] #189

@danpawlik danpawlik force-pushed the export-kubeconfig branch 2 times, most recently from 7403006 to 44908f1 Compare July 9, 2024 07:15
Each of the "oc" command that is veryfing the resource
is exiting with error code 1, because the KUBECONFIG is not available.

This commit is partially revert code that was proposed in [1].

[1] crc-org#189
@danpawlik danpawlik force-pushed the export-kubeconfig branch from 44908f1 to 7a9f044 Compare July 9, 2024 07:16
@praveenkumar praveenkumar merged commit 32e5222 into crc-org:main Jul 9, 2024
2 of 3 checks passed
@danpawlik danpawlik deleted the export-kubeconfig branch July 9, 2024 07:35
rdoproject pushed a commit to rdo-infra/review.rdoproject.org-config that referenced this pull request Jul 9, 2024
Added improvements:
- the generated ssh pub key is also added to the authorized keys because
  of the machineconfig
- export the KUBECONFIG variable, due it was changed to the local
  variable [1], so the oc command were failing with exit code 1. More
  info [2].
- set realpath for log file

[1] crc-org/crc-cloud#189
[2] crc-org/crc-cloud#191

Change-Id: I8ef8cf2a7742cb396671ebcfa7b8d585730158f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants