[crc-support] fix: task using single quotes do not evaluate as expecting #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
force-pushed
the
crc-support-fix-evaluation
branch
2 times, most recently
from
883418e to
d682667
Compare
albfan
approved these changes
Nov 29, 2024
…non linux envs.
This commit also fix the pusher issue with the task filename
Signed-off-by: Adrian Riobo <[email protected]>
adrianriobo
force-pushed
the
crc-support-fix-evaluation
branch
from
d682667 to
3a2a56a
Compare
adrianriobo
changed the title
adrianriobo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix the issue where the username is not evaluated as part of the target-path giving a wrong value when used with bundles / binaries.