WIP: chore: migrate crc-e2e #39
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyLuLiu
reviewed
Oct 23, 2024
lilyLuLiu
reviewed
Oct 23, 2024
lilyLuLiu
reviewed
Oct 23, 2024
lilyLuLiu
reviewed
Oct 23, 2024
albfan
force-pushed
the
crc-e2e
branch
2 times, most recently
from
ddae45a to
929a2f9
Compare
adrianriobo
reviewed
Oct 25, 2024
| description: type of arch (amd64, arm64). Defaults amd64 | ||
| default: amd64 | ||
| # remote target host params | ||
| - name: host |
There was a problem hiding this comment.
Would suggest to change this to a Workspace having the structure similar to a secret
| run: | | ||
| echo ${{ env.image }} > crc-e2e-image | ||
| echo ${{ github.event_name }} > crc-e2e-build-event | ||
|
|
There was a problem hiding this comment.
Same as previous, it applies in general to all build job
|
|
||
| jobs: | ||
| push: | ||
| name: push |
There was a problem hiding this comment.
Same as for other gh action flow, all oci related steps should be removed
albfan
force-pushed
the
crc-e2e
branch
3 times, most recently
from
15920dc to
24acfec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrates crc-e2e from qe-platform.
relates #30