Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AST extension #583

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Halleck45
Copy link
Contributor

@Halleck45 Halleck45 commented Dec 26, 2024

Hi,

Thank you for this tool; it's a really great idea!

This PR adds support for the ast extension (at least on Linux).

  1. I wasn't able to test the build on Mac. Could a Mac owner test it? (./bin/spc build --build-cli ast)
  2. Is there anything to do to update the list of supported extensions on the documentation website?

Thanks!

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added enhancement New feature or request kind/extension Issues related to extensions labels Dec 26, 2024
@crazywhalecc
Copy link
Owner

Thanks for your contribution! The ast extension seems to be possible now. I will modify it to support it directly if you don't mind.

There are tests for MacOS and Linux, which can be tested by modifying the variables at the top of the src/globals/test-extensions.php file.

@crazywhalecc crazywhalecc merged commit 20dad4c into crazywhalecc:main Jan 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/extension Issues related to extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants