Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI and Sandbox: Temporarily remove use of uv #37

Merged
merged 1 commit into from
Dec 5, 2024
Merged

CI and Sandbox: Temporarily remove use of uv #37

merged 1 commit into from
Dec 5, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 5, 2024

uv provided some hiccups in dependency resolutions, so we are trying without, in order to check if this improves the situation, or if it's unrelated.

Most prominently, the update to a higher version of pandas still does not succeed after many cycles to make it so.

It provided some hiccups in dependency resolutions, so we are trying
without, in order to check if this improves the situation, or if it's
unrelated.
@amotl amotl marked this pull request as ready for review December 5, 2024 21:51
@amotl amotl merged commit 76e6494 into main Dec 5, 2024
2 checks passed
@amotl amotl deleted the remove-uv branch December 5, 2024 21:51
@charliermarsh
Copy link

So sorry to bother but for my own prioritization, are you able to share the resolution that didn't succeed? Is it:

cratedb-toolkit[datasets]==0.0.29
ipyleaflet<0.20
kaleido<0.3
llvmlite>=0.40
pandas<2.1
pandas<2.3
plotly<5.25
pycaret>=3,<3.4
pydantic<3
refinitiv-data<1.7
sqlalchemy<2.1
sqlalchemy-cratedb==0.40.1

@amotl
Copy link
Member Author

amotl commented Dec 8, 2024

Dear Charlie,

thanks a stack for your reply, and sorry for missing it.

for my own prioritization

TLDR; Any issues on our ends have been resolved well. @zanieb educated us about astral-sh/uv#8157, but I am no longer sure this was even the problem here. Thank you both for your time and diligence on supporting us and tracking this back.

With kind regards,
Andreas.

Details

The issue has been resolved and we swapped uv back in per GH-39. The problem originated because of the constraint limit pandas<2.1, which, when resolved per GH-27, did no longer cause any issues, afair.

able to share the resolution that didn't succeed?

Because you are listing pandas<2.1, I guess your enumeration is on the right track. Please note, however:

Thoughts

Apparently, this tripped us because of some resolution issue around llvmlite, the first one @konstin is enumerating within the Known Cases section at astral-sh/uv#8157. I guess it is pandas/numpy, which is pulling in llvmlite?

In this spirit, I think the constellation of dependencies can be made much smaller to be reproducable, if it's just revolving about this small subset of dependencies that goes south?

Conclusion

Wrapping up, I think the noise was more about our own sillyness than about a serious issue we observed with uv. If you think differently, and our constellation of dependencies can support you to work on astral-sh/uv#8157 in any way, please let us know any time. We can easily travel back in time of the repository history to get you a dependency dump using pipdeptree, or any other incantation of uv with relevant debug options you may advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants