chore: remove TODOs in Csharp code #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Aug 14, 2024
| @@ -7,8 +7,6 @@ | |||
| import java.nio.file.StandardCopyOption; | |||
|
|
|||
| public class LibEthKZG implements AutoCloseable{ | |||
| // TODO: Add equality tests | |||
kevaundray
commented
Aug 14, 2024
Comment on lines
-137
to
+130
| // Current version of c-kzg does not support arm windows either | ||
| // TODO: Rust has support for msvc with arm64, but it also has: | ||
| // aarch64-pc-windows-gnullvm -- we probably want to stick to one | ||
| // toolchain for now. | ||
| // If we do switch to msvc, nethermind had an issue with windows server 2022 | ||
| // that we should check works with an msvc build. | ||
| // libraryResourcePath = "/aarch64-pc-windows-gnullvm/" + PLATFORM_NATIVE_LIBRARY_NAME; | ||
| // We currently do not support arm on windows |
kevaundray
commented
Aug 14, 2024
Comment on lines
-47
to
-49
| // TODO: Finalization was deprecated, we should find a method that does | ||
| // TODO: not require a lot of code. Possibly separate the wrapper from the | ||
| // TODO: bindings code too. |
kevaundray
commented
Aug 14, 2024
Comment on lines
-62
to
-63
| // TODO: we could move this to the rust code but it requires a double pointer | ||
| // TODO: add this code to all bindings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.