loading custom profile vs generic connect.c4m #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
commented
Aug 20, 2024
setup.sh
Outdated
Comment on lines
7
to
8
| OPENID_CONNECT=https://chalk-test.crashoverride.run/v0.1/openid-connect/github | ||
| PROFILE=https://chalk-test.crashoverride.run/v0.1/profile |
There was a problem hiding this comment.
- need to flip to prod before merging
|
this should not be merged until the UI is fully deployed into prod |
|
This should be all ok to merge @miki725 👍 |
| PROFILE=https://chalk.crashoverride.run/v0.1/profile | ||
| GITHUB_OPENID_CONNECT=https://chalk.crashoverride.run/v0.1/openid-connect/github | ||
| GITLAB_OPENID_CONNECT=https://chalk.crashoverride.run/v0.1/openid-connect/gitlab | ||
| if [ -n "${__CHALK_TESTING__:-}" ]; then |
There was a problem hiding this comment.
Non-blocking: We should document this feature clearly in notion before we forget and call it out on a team meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the action was hard coding the use of
connect.c4mwhich allowed to connect Chalk to CrashOverride.This change allows to connect Chalk to a custom profile as configured in CrashOverride UI. The rough flow is:
This allows friction-free UX across multiple CI systems with fully custom chalk profiles. Currently supports:
For CI systems which do not support this feature the
--tokencan be manually passed which will point chalk to the CrashOverride org without OIDC tokens.