Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporting GITHUB_TOKEN #11

Merged
merged 1 commit into from
May 30, 2024
Merged

exporting GITHUB_TOKEN #11

merged 1 commit into from
May 30, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented May 29, 2024

as chalk github plugin attempts to talk to github API, it now requires access to GITHUB_TOKEN and so we automatically export it to ensure chalk can complete its metadata collection

this is required to make crashappsec/chalk#303 work

as chalk github plugin attempts to talk to github API, it now requires
access to GITHUB_TOKEN and so we automatically export it to ensure
chalk can complete its metadata collection
@miki725 miki725 requested a review from MyNameIsMeerkat May 29, 2024 18:12
Copy link

@MyNameIsMeerkat MyNameIsMeerkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miki725 miki725 merged commit 0ff4814 into main May 30, 2024
2 checks passed
@miki725 miki725 deleted the token branch May 30, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants