Initial action implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
force-pushed
the
initial
branch
30 times, most recently
from
28203df to
d4e49c4
Compare
miki725
force-pushed
the
initial
branch
18 times, most recently
from
5d35601 to
f348446
Compare
indecisivedragon
approved these changes
Oct 5, 2023
| url=$URL_PREFIX/$(chalk_version_name) | ||
| info Downloading chalk from "$url" | ||
| rm -f "$TMP/$name"{,.sha256} | ||
| wget --quiet --directory-prefix=$TMP "$url"{,.sha256} || ( |
There was a problem hiding this comment.
I'm not 100% on Github's macosx runners, but wget isn't available by default in macos. curl usually is though
There was a problem hiding this comment.
|
|
||
| # get the chalk file name for the version/os/architecture | ||
| function chalk_version_name { | ||
| echo "chalk-$version-$(uname -s)-$(uname -m)" |
There was a problem hiding this comment.
just flagging here that that uname -s will return Darwin on macosx boxes. We have packages generated server side that will correctly resolve to 'Darwin' but just flagging as 'macos' is often used elsewhere.
NOT broken, just noting
There was a problem hiding this comment.
this is expected behavior. we upload Darwin variant to the release folder for this reason so the download is super simple without any conditional logic
MyNameIsMeerkat
requested changes
Oct 5, 2023
MyNameIsMeerkat
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic implementation of the action to setup chalk in github actions. The script:
$HOME/.chalk/bintoPATH$HOME/.chalk/bin/chalkdockercommand in$HOME/.chalk/bin/dockerAction shows basic logic which shows up as:
However if debug logging is enabled, the script enables
set -xin bash which will show all executed commands (a bit verbose but shows exactly what it does) in addition to showing all chalk output as verboseThere are 3 types of actions in github:
Composite action was chosen as it allows to execute a basic bash script which potentially can be reused to install
chalkin other CI environments/containers