ending switchboard loop when select returns 0 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this happens when subprocess doesnt do much IO and so subprocess completes even though it has no ready FDs so we should finish loop even when its ==0 vs previously it was only accounting for >0 note that we still only handle ready writes/reads when select returns >0 as there is no point in handling FDs when they have nothing ready yet
viega
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this happens when subprocess doesnt do much IO and so subprocess completes even though it has no ready FDs so we should finish loop even when its ==0 vs previously it was only accounting for >0
note that we still only handle ready writes/reads when select returns >0 as there is no point in handling FDs when they have nothing ready yet