Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC for next version #34

Merged
merged 17 commits into from
Nov 17, 2023
Merged

RC for next version #34

merged 17 commits into from
Nov 17, 2023

Conversation

viega
Copy link
Contributor

@viega viega commented Nov 17, 2023

Lots of polish work:

  1. The 3rd party libraries needed by nimutils are all moved here.
  2. Integrated my lock-free hash table.
  3. Fixed a bug that was causing stuff to disappear in chalk sometimes.
  4. Fleshed out the rope API with LOTS of niceties.
  5. Documented most calls worth documenting (stuff I don't plan to deprecate mainly is what remains).

#3 was the hardest... basically I kept trying to figure out what was happening, so kept rewriting bits more cleanly, and eventually seemed like it was worth finishing #4.

And now, for at least 5 minutes, I don't know of any rendering issues (even in the release I knew of a couple but there were workarounds for anything that would show).

viega added 17 commits November 12, 2023 23:56
…ll the wrapper code is anywya.

2. Moved the new hash table here.
3. Did a lot of polish, partially around ropes / tables.
4. Finally integrated the mac process info stuff.
5. Moved around a bunch of the C code to be better organized.
6. Moved all the one-off test cases to nimutils.nim, and now have it produce an exe

There are some minor breaking changes in here.
…orted function seems to clober local variables in templates? Conform tok() function was picking up the s() from here where it needs the 's' object in lex()
…e modules to get through, but am nearly done.
… debugging tools, and so on. Needs a bit more documentation for the new stuff. Also, I found a new bug while adding this stuff... in some cases margins get eaten when a real container is inside a formatting box. Will fix soon.
… any kind! Now I just have to update everything else :(
@viega viega merged commit 5b97ca1 into dev Nov 17, 2023
1 check failed
@viega viega deleted the jtv/polish branch November 17, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant