breaking out of retry loop on success

crashappsec · Aug 13, 2024 · c3b44fa · c3b44fa
1 parent 7e435fa
commit c3b44fa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/nimutils/net.nim b/nimutils/net.nim
@@ -131,6 +131,7 @@ template withRetry(retries: int, firstRetryDelayMs: int, c: untyped) =
   while attempts <= retries:
     try:
       c
+      break
     except:
       if attempts == retries:
         # reraise last exception to bubble error up
@@ -139,7 +140,6 @@ template withRetry(retries: int, firstRetryDelayMs: int, c: untyped) =
       if delayMs > 0:
         sleep(delayMs)
       attempts += 1
-  raise newException(ValueError, "retried code block didnt return. this should never happen")
 
 proc check*(response: Response,
             url: Uri | string,