feat(config): Load and configure components without editing configs directly #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial (untested) integration of new Con4m component system.
…d tag (#45) * fix(docker): fixing flaky heartbeat test The root cause was that probe build to get current build platform, docker tag name was random which sometimes resulted in invalid tag names: ``` ERROR: invalid tag ".mpiljfkim.ahsfgpf3f4g": invalid reference format ``` docker tag names need to start/end with alphanumeric character so to solve it adding "chalk_" and `_probe" prefix/suffix. This ensures the build tag is correct and docker can build it. * test(docker): allowing log_level arg to docker_build * test(heartbeat): heartbeat test with trace log level this test case is flaky so adding trace log level hopefully will help to diagnose the issue further in addition as in case cases trace log will include reports internally adjusting report parsing logic to ignore any log lines which should only find valid json reports in the output * doc(release): adding release note for wrap entrypoint fix also fixing spelling typos in rest of the doc * refactor: using common chooseNewTag everywhere for docker build
Basic integration of the Con4m component system, including caching modules and parameters in the self-chalk mark. There are a number of enhancements that should happen, but I don't think they need to happen right away (I may come back to them): 1) A nicer GUI to this (which is probably my #1 priority here) 2) A non-interactive way of setting parameters when doing a chalk load. I was thinking maybe a flag plus reading json over stdin, dunno. 3) Documentation in-command; I also need to update the design doc to reflect the changes I made. 4) I skipped a lot of the work on version checking; it didn't feel quite right, or all that urgent. 5) Definitely should exercise it all a bit more. It's a huge addition in many respects, and there are probably plenty of edge cases, etc. that aren't working.
|
This is probably ready (and big enough) for others to start tire kicking. Once I update the design doc, I'll update the ticket description and move this out of draft. |
viega
changed the title
|
Seems like virtually all tests fail here. That's surprising; I was expecting things around |
|
My initial guess is that, since most of the tests are loading a config, there's some unintended consequence that I wasn't thinking about. Come to think about it, the tests definitely need to start passing |
…port it as a module)
… attempted (still checks whther it loads or not)
miki725
reviewed
Oct 13, 2023
3 tasks
…gging. This might break though due to the new IO stuff.
… Still a few failing tests.
miki725
force-pushed
the
jtv/components
branch
from
7d94880 to
4c4c350
Compare
viega
changed the title
drraid
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial (untested) integration of new Con4m component system.
Issue
Closes #31
Description
Implements the initial component system that allows people to try out examples simply via
chalk load.See documentation here: #30
Testing
Let's build out as many real configurations as practical that we'd actually like to provide by default, and then see how they run!