Added inheritance of exceptions for the ability to catch errors #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error($ error, 'jsonrpc');
cranetm
approved these changes
Jan 11, 2018
cranetm
requested changes
Jan 11, 2018
| @@ -73,27 +73,23 @@ private function bringValueToType($parent, $type, $value) | |||
| ); | |||
There was a problem hiding this comment.
Please review carefully http://www.jsonrpc.org/specification, array-type does not allow.
There was a problem hiding this comment.
and why you'he commited this in not your topic?
now i cannot merge all changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That errors were logged by the standard mechanism Yii::error($ error, 'jsonrpc');