Various changes to make it easier to extend the theme #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try it in with the exemple. And if everuhings work I merge this PR. |
| @@ -112,7 +112,7 @@ h6 { | |||
| .contact { | |||
| padding: 100px 0; | |||
| color: #f8f8f8; | |||
| background: url(../img/contact-bg.jpg) no-repeat center center; | |||
| background: url(/img/contact-bg.jpg) no-repeat center center; | |||
There was a problem hiding this comment.
Hello, your PR looks good and I merged this branch personally 😃 .
However, I only think this url should be remained as relative path because hugo's canonifyUrls option doesn't work at urls in css files
so that this will cause a problem if you deploy the site not on a root path (e.g. http://example.com/foo/)
There was a problem hiding this comment.
But it will fail if you have any kind of nesting … but ok, I amended the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits are trivial changes that I made to the theme for my local use case which are trivial and make it a lot easier to extend the theme. I'm not sure which of these are interesting to you, but I figured I'd offer them because they were helpful to me.
Thank you for making your great theme available!