Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/16181 number field amends #16192

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Nov 22, 2024

Description

In v4, if you type 5.6 into a number field which has decimals set to zero, the value stored in the DB is 5; the value displayed in the control panel and on the front end is also 5 (that’s because the decimals setting affected the type of column the data was saved to).
In v5, it’s

  • stored as 5.6
  • displayed on the front end as 5.6
  • and in the control panel:
    • in the field and in element indexes as 6 if the preview format is “as decimal values” (default)
    • in the field as 6 and in element indexes 5.60 if the preview format is “as currency values”
    • in the field and in element indexes as 5.6 if the preview format is “unformatted”

Since we no longer rely on column types, normalisation should take care of ensuring the field’s decimals setting is respected.

Related issues

#16181

@brandonkelly brandonkelly merged commit 24341a6 into 5.x Nov 22, 2024
3 checks passed
@brandonkelly brandonkelly deleted the bugfix/16181-number-field-amends branch November 22, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants