Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for translator 3.15.0 #43

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

elsaperelli
Copy link

This PR bumps the version of the CQL translator from 3.7.1 to 3.15.0. Release notes for 3.15.0 can be found here.

Summary of changes:

  • In CQL translator version 3.10.0 (release notes here), JUnit was updated to JUnit 5. I found this page useful for the updates made in FormatterResourceTest.java and TranslationResourceTest.java.
    • Please make sure I didn't miss anything else.
  • Due to upgrading JUnit I also had to upgrade jersey and jaxb-runtime.

@hossenlopp hossenlopp self-requested a review September 18, 2024 17:10
Copy link
Collaborator

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and tests out with retranslating measures.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Elsa!

I made one nit-picky comment about indented XML. I also noticed that this is out of sync with master; could you please merge or rebase to get in sync?

I assume that we will also want a new release (which would be release 2.5.0), so we will need to update the release number from 2.4.0 to 2.5.0 in:

  • pom.xml
  • Dockerfile
  • README.md (two places, and also reflect the translator version 3.15.0 in the table)

We can either do that in this PR too (so we're ready to release right away) or we can put the 2.5.0 version bump in a separate PR following this one. I don't have a strong preference, so whatever is easier from your perspective.

Also -- don't worry about the failed GitHub Action for the Docker publish; that's actually probably a good thing (since we probably shouldn't push to DockerHub from forks).

pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Elsa! I tested this manually as well as through Docker and all functionality is working as expected. And the JUnit 5 tests looks great. Thanks!

@hossenlopp hossenlopp self-requested a review September 19, 2024 15:26
@cmoesel cmoesel merged commit 7b34485 into cqframework:master Sep 19, 2024
1 of 2 checks passed
@elsaperelli elsaperelli deleted the upgrade-translator branch September 19, 2024 15:35
@elsaperelli elsaperelli restored the upgrade-translator branch November 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants