-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for translator 3.15.0 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and tests out with retranslating measures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Elsa!
I made one nit-picky comment about indented XML. I also noticed that this is out of sync with master; could you please merge or rebase to get in sync?
I assume that we will also want a new release (which would be release 2.5.0), so we will need to update the release number from 2.4.0 to 2.5.0 in:
pom.xml
Dockerfile
README.md
(two places, and also reflect the translator version 3.15.0 in the table)
We can either do that in this PR too (so we're ready to release right away) or we can put the 2.5.0 version bump in a separate PR following this one. I don't have a strong preference, so whatever is easier from your perspective.
Also -- don't worry about the failed GitHub Action for the Docker publish; that's actually probably a good thing (since we probably shouldn't push to DockerHub from forks).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Elsa! I tested this manually as well as through Docker and all functionality is working as expected. And the JUnit 5 tests looks great. Thanks!
This PR bumps the version of the CQL translator from
3.7.1
to3.15.0
. Release notes for3.15.0
can be found here.Summary of changes:
3.10.0
(release notes here), JUnit was updated to JUnit 5. I found this page useful for the updates made inFormatterResourceTest.java
andTranslationResourceTest.java
.