Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.0 w/ support for Translator 3.3.2 #39

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Nov 7, 2023

Update the translator to the latest one in the 3.x line. This required code changes, as the Translator classes have been refactored. The basic use and API of the service, however, has not changed, so this is only a minor bump in regard to the service version.

Once DockerHub has built this, you should be able to test it in docker using:

$ docker run -p 8080:8080 cqframework/cql-translation-service:pr-39

Update the translator to the latest one in the 3.x line. This required code changes, as the Translator classes have been refactored.
@cmoesel cmoesel requested a review from hossenlopp November 7, 2023 17:16
Copy link
Collaborator

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests out with our fqm-execution fixture setup.

@cmoesel cmoesel merged commit 7dbd46c into master Dec 1, 2023
3 checks passed
@cmoesel cmoesel deleted the translator_3.3.2 branch December 1, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants