Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VO-1194] feat: Hide shortcut badge when for some context #2247

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

cballevre
Copy link
Contributor

@cballevre cballevre commented Nov 15, 2024

### ✨ Features
 
*  Hide shortcut badge when for some context with `hide_shortcut_badge_on_home`

Related PRs:

This caused the application to crash if a folder was created on Drive while Home was open at the same time. This was due to real time adding the folder but without attributes because it didn't use json-api.
This make the shortcut tile appears more like apps in some case it could be useful
Before, only way to de-group was to click on the  switch. Now it's the line in the options menu that does the action (the switch is contained inside).

I've taken advantage of this to make the user return to the root when he chooses to ungroup a folder so that he doesn't stay on a route that doesn't display anything. This could lead to strange behaviour when they chose to group it again
@cballevre cballevre force-pushed the feat/hide-shortcut-badge branch from b5d73d8 to c3141a3 Compare November 18, 2024 10:13
Copy link

bundlemon bot commented Nov 18, 2024

BundleMon

Files updated (2)
Status Path Size Limits
app/home.(hash).js
56.25KB (+70B +0.12%) -
vendors/home.(hash).js
1.57MB (-25B 0%) -
Unchanged files (11)
Status Path Size Limits
services/softDeleteOrRestoreAccounts/home.js
466.04KB -
services/updateAccounts/home.js
463.17KB -
services/deleteAccounts/home.js
311.82KB -
services/myselfFromIdenties/home.js
236.25KB -
services/polyfillFetch/home.js
97.38KB -
vendors-home.(hash).(hash).min.css
37.78KB -
intents/home.(hash).js
26.57KB -
services/attributesHelpers/home.js
15.22KB -
app-home.(hash).min.css
2.21KB -
intents/index.html
652B -
intents-home.(hash).min.css
158B -

Total files change +44B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cballevre cballevre merged commit 4419c2e into master Nov 18, 2024
4 checks passed
@cballevre cballevre deleted the feat/hide-shortcut-badge branch November 18, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants