Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant: Clear search when clicking outside on the input on desktop #2229

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Oct 28, 2024

No description provided.

@JF-Cozy JF-Cozy changed the base branch from master to feat/VER-1033 October 28, 2024 13:57
Copy link

bundlemon bot commented Oct 28, 2024

BundleMon

Files updated (2)
Status Path Size Limits
app/home.(hash).js
55.74KB (+23B +0.04%) -
vendors/home.(hash).js
1.54MB (+18B 0%) -
Unchanged files (11)
Status Path Size Limits
services/softDeleteOrRestoreAccounts/home.js
464.4KB -
services/updateAccounts/home.js
461.47KB -
services/deleteAccounts/home.js
309.8KB -
services/myselfFromIdenties/home.js
234.35KB -
services/polyfillFetch/home.js
97.37KB -
vendors-home.(hash).(hash).min.css
38.79KB -
intents/home.(hash).js
27.38KB -
services/attributesHelpers/home.js
15.22KB -
app-home.(hash).min.css
2.18KB -
intents/index.html
650B -
intents-home.(hash).min.css
158B -

Total files change +41B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

{searchValue && <ResultMenu anchorRef={searchRef} onClick={onClick} />}
</>
<ClickAwayListener onClickAway={onClear}>
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste pour ma culture: pourquoi un span et pas un div ici?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClickAwayListener attend un seul enfant, pas possible de mettre plusieurs enfants comme ici. Mais on veut englober les deux dans le ClickAwayListener. Sauf que pour ça je ne veux pas toucher au style, dans ces cas là perso j'utilise plus un span qu'un div, par habitude un display inline "casse" moins le style prédéfinit qu'un display block, mais je t'avoue que j'ai pas testé avec un div

Base automatically changed from feat/VER-1033 to master October 28, 2024 14:03
@JF-Cozy JF-Cozy merged commit ecd375c into master Oct 28, 2024
4 checks passed
@JF-Cozy JF-Cozy deleted the feat/VER-1021 branch October 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants