Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix decimals and update lists #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 17, 2024

This PR fixes the decimals for PRO token with address 0x18dD5B087bCA9920562aFf7A0199b96B9230438b in Base chain.

It had 18 decimals, but the contract has 8. See https://basescan.org/token/0x18dD5B087bCA9920562aFf7A0199b96B9230438b

I re-generated the lists too. I will point in the code the most relevant change. The rest is the update of the most trade token lists.

Why it was wrong? I'm not sure, but I think its because the token had the wrong decimals in the Coingecko list we use to load the tokens

https://tokens.coingecko.com/uniswap/all.json

@@ -791,17 +799,9 @@
"address": "0x18dd5b087bca9920562aff7a0199b96b9230438b",
"name": "Propy",
"symbol": "PRO",
"decimals": 18,
"decimals": 8,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants