Use new database layout #75
Conversation
src/helpers/blockchain_data.py
Outdated
| @@ -71,3 +74,34 @@ def get_auction_id(self, tx_hash: str) -> int: | |||
| # convert bytes to int | |||
| auction_id = int.from_bytes(call_data_bytes[-8:], byteorder="big") | |||
| return auction_id | |||
|
|
|||
|
|
|||
| def get_transaction_timestamp(tx_hash: str, web3: Web3) -> tuple[str, int]: | |||
There was a problem hiding this comment.
Is there a reason these are not defined as methods of the BlockchainData class?
There was a problem hiding this comment.
It should be made a method of that class.
I just moved it around a bit and did not want to have it depend on all the other things for computing imbalances or even a chain name in this blockchain fetcher. Testing was a bit easier if those methods are standalone.
|
The database setup seems to be working more or less now. Testing price fetching currently seems to require api keys. The coingecko price fetcher cannot be set up since the token list cannot be fetched. (The actual price fetching contains special treatment for not having a key, but that part of the code cannot be reached.) |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected] |
|
Pushed a commit that comments out the old code except for the raw token imbalances calculation. The writing in the new tables is also based in the token imbalances token list, as this is more efficient (as we do not need prices for tokens with an imbalances of exactly zero). Merging so as to test for a few hours/days. A folllow-up clean-up PR should follow. Note: all new db tables have been manually created based on the definitions used in this PR. |
This
is a work-in-progressPR for using the database tables. It is not meant for review but more as a record of the current state of the implementation.Current state
(at most) oneALL available prices per tokenNext steps