Use multiple price feeds always #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Oct 4, 2024
| for provider in self.providers: | ||
| try: | ||
| price = provider.get_price(price_params) | ||
| if price is not None: | ||
| return price, provider.name | ||
| prices.append((price, provider.name)) | ||
| except Exception as e: | ||
| logger.error(f"Error getting price from provider {provider.name}: {e}") |
There was a problem hiding this comment.
This being an error message sounds a bit strange. Most errors should be caught explicitly and would be more of a info type thing.
| @@ -290,15 +289,21 @@ def handle_fees( | |||
| ) | |||
|
|
|||
| def handle_prices( | |||
There was a problem hiding this comment.
This name sounds a bit strange. Maybe store_prices would work.
| ) | ||
| self.log_message.append( | ||
| f"Token: {token_address}, Price: {price} ETH, Source: {source}" | ||
| ) | ||
| except Exception as err: | ||
| logger.error(f"Error: {err}") |
There was a problem hiding this comment.
Suggested change
| logger.error(f"Error: {err}") | |
| logger.error(f"Error writing prices to database: {err}") |
Merged
fhenneke
added a commit
that referenced
this pull request
Oct 4, 2024
|
Should have probably pushed a different button to revert this. Not sure how to reopen the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we have used an ordering of price feeds, in the sense that we query the first API, and if it succeeds, we stop, and only continue with the second price feed if the first one doesn't respond. This PR changes this by forcing the use of all available price feeds/apis always.