Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata issue #55

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix metadata issue #55

merged 2 commits into from
Sep 7, 2024

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Sep 7, 2024

The code assumes that there is always a "metadata" key in the appdata dictionary. This is not always the case; see e.g, this order. In such cases, the script produces an error

    if "partnerFee" in app_data["metadata"].keys():
                       ~~~~~~~~^^^^^^^^^^^^
KeyError: 'metadata'

This PR addresses this.

Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping this without review.

@harisang harisang merged commit b356e66 into main Sep 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants