Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block range query #496

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update block range query #496

merged 1 commit into from
Jan 16, 2025

Conversation

harisang
Copy link
Contributor

This PR changes the query id of the block range query. The two queries are identical but only one of them is under version control and also used by the main Dune rewards dashboard.

@harisang harisang requested a review from fhenneke January 16, 2025 13:34
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was probably a left over from making the script multi-chain. The id from this PR is the correct one, see https://github.com/cowprotocol/dune-queries/blob/main/cowprotocol/accounting/rewards/block_number_interval_from_time_interval_query_3333356.sql.

@harisang harisang merged commit 7a72007 into main Jan 16, 2025
6 checks passed
@harisang harisang deleted the update_block_interval_query branch January 16, 2025 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants