Update dependencies #490
Merged
Update dependencies #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename gnosis to safe_eth - update network name of base
use connection instead of engine
harisang
reviewed
Jan 13, 2025
| log.info("Running prod query for first connection (in get_solver_rewards)") | ||
| results.append( | ||
| self.exec_query(query=batch_reward_query_prod, engine=self.connections[0]) | ||
| ) | ||
| for engine in self.connections[1:]: | ||
| # query for barn database |
There was a problem hiding this comment.
This technically changes the behavior but the list never had length more than 2
harisang
approved these changes
Jan 13, 2025
|
Merging so that we test with tomorrow's payouts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update dependencies and closes #489.
Main changes:
byteswhich required updating the corresponding test, and some input changed trom a string to a checksumed string.withblock was required to close the connection. Alternatively, one could have explicitly called a commit function.I will probably bound from below some of the packages we use. I also want to understand why web3 is still held back to 6.X instead of the latest stable version 7.X.
I have tested the changes with the main payout in the accounting week 2024-12-31 to 2025-01-07. I tested that the base code does not crash at the point where it did before. Actually posting a transaction has not been done.