[Ethflow] using the newest contract #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josojo
commented
Nov 7, 2022
| self.extract_custom_and_general_order_data(events).await?; | ||
| let order_placement_events = events | ||
| .into_iter() | ||
| .filter(|EthContractEvent { data, .. }| { |
There was a problem hiding this comment.
This is only temporary. THe next PR will also index for the new cancellation event properly
| @@ -19,16 +19,7 @@ fn main() { | |||
| println!("cargo:rerun-if-changed=build.rs"); | |||
|
|
|||
| generate_contract_with_config("CoWSwapEthFlow", |builder| { | |||
| builder | |||
| .contract_mod_override("cowswap_eth_flow") | |||
There was a problem hiding this comment.
We decided to deploy 1 contract for staging and 1 for prod. Hence, I don't import contract address as before, but rather via env variables
nlordell
reviewed
Nov 7, 2022
nlordell
reviewed
Nov 7, 2022
nlordell
approved these changes
Nov 7, 2022
MartinquaXD
approved these changes
Nov 8, 2022
crates/refunder/src/arguments.rs
Outdated
| @@ -45,6 +54,7 @@ impl std::fmt::Display for Arguments { | |||
| writeln!(f, "min_slippage_bps: {}", self.min_slippage_bps)?; | |||
| writeln!(f, "db_url: SECRET")?; | |||
| writeln!(f, "node_url: {}", self.node_url)?; | |||
| writeln!(f, "ethflow_contract: {}", self.ethflow_contract)?; | |||
There was a problem hiding this comment.
Suggested change
| writeln!(f, "ethflow_contract: {}", self.ethflow_contract)?; | |
| writeln!(f, "ethflow_contract: {:?}", self.ethflow_contract)?; |
With Display formatting: ethflow contract: 0x26c3…2830
With Debug formatting: ethflow contract: 0x26c3801b4840dab317cedfd7aeaf9f45fdd22830
I suggest the same change for the autopilot crate as well.
vkgnosis
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the newest contracts. I needed to update ethcontract, due to cowprotocol/ethcontract-rs#854