Rename constructors to try_new
#3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Thanks for the PR. Next step is to make our tests pass. Can you check all the failing CI runs and look for errors and fix them? |
|
I've fix the ci jobs for |
It is not possible to run this test from a forked repo for security reasons. We should probably add a reminder about that to all the external submissions. |
|
So, what should I do from my side? |
…targets -- -D warnings"
MartinquaXD
approved these changes
Jan 2, 2025
There is no need to do anything from your side. Thank you for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR try to tackle issue #3179.
Changes
Resulttotry_new.How to test
Existing unit test.