Separate the DB configuration #3198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
commented
Dec 31, 2024
| @@ -54,6 +54,10 @@ pub struct Arguments { | |||
| #[clap(long, env, default_value = "postgresql://")] | |||
| pub db_url: Url, | |||
There was a problem hiding this comment.
To be removed once the config is migrated to the new one.
m-lord-renkse
commented
Dec 31, 2024
| @@ -40,6 +40,10 @@ pub struct Arguments { | |||
| #[clap(long, env, default_value = "postgresql://")] | |||
| pub db_url: Url, | |||
m-lord-renkse
force-pushed
the
separate-db-configuration
branch
2 times, most recently
from
fc2a04e to
0a34b0c
Compare
m-lord-renkse
force-pushed
the
separate-db-configuration
branch
from
0a34b0c to
ff72371
Compare
MartinquaXD
reviewed
Dec 31, 2024
There was a problem hiding this comment.
The reason of doing this is to add an extra layer of safety handing the DB credentials.
Could you provide more details how this gives us extra safety?
Also why is a change in the services repo needed? Wouldn't it be sufficient to handle these things separately in the infra repo and then assemble the individual parts to a single URL?
m-lord-renkse
commented
Dec 31, 2024
| #[derive(Clone, clap::Parser)] | ||
| pub struct Db { | ||
| /// Base Url of the Postgres database | ||
| pub db_base_url: Option<Url>, |
There was a problem hiding this comment.
Set this URL non Option with a default. TODO after the configuration is migrated to the new one.
m-lord-renkse
commented
Dec 31, 2024
| impl Db { | ||
| /// Returns the DB URL with credentials | ||
| /// Returns `None` if the URL is not configured | ||
| pub fn to_url(&self) -> Option<Url> { |
There was a problem hiding this comment.
After the configuration is changed, this will return directly an Url
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the DB configuration into base URL, user and password.
The reason of doing this is to add an extra layer of safety handing the DB credentials.
How to test