Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Remove enable_multiple_fees config #3155

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Dec 10, 2024

Description

This config was added for one purpose only - to coordinate with accounting team when and how to turn on the feature - reference #2595 (review)

Since battled tested, this can be removed now.

Will create the PR for infrastructure as well. Edit: https://github.com/cowprotocol/infrastructure/pull/2394

Changes

  • Remove enable_multiple_fees

How to test

e2e tests

@sunce86 sunce86 self-assigned this Dec 10, 2024
@sunce86 sunce86 requested a review from a team as a code owner December 10, 2024 14:50
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪚

@sunce86 sunce86 merged commit 665e401 into main Dec 10, 2024
11 checks passed
@sunce86 sunce86 deleted the remove-multiple-fees-config branch December 10, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants