Stop using string for solution_id #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
approved these changes
Dec 10, 2024
squadgazzz
approved these changes
Dec 12, 2024
|
@sunce86 what's the status of the solver teams? Can this be merged? |
|
@bram-vdberg forgot to ping you about this on Friday, any objections from solvers? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up for #3152, and a final step to switch to using INTEGER for solution id only.
Will be merged on Friday, once all solvers confirm they updated their drivers to include #3152.
OPENAPI is already up to date.
Fixes #3072
Changes
How to test
e2e tests